Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(occupancy_grid_map_outlier_filter)!: fix namespace and directory structure #7748

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jun 28, 2024

Description

This PR puts headers in the autoware namespace.

Additional works

  1. Align directory structure to follow the coding guidelines.
  2. Clean unused dependencies LIST

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.
TIER IV INTERNAL

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 28, 2024
Copy link

github-actions bot commented Jun 28, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the refactor/namespace-occupancy_grid_map_outlier_filter branch from 1e8504c to f328151 Compare June 28, 2024 08:32
@technolojin technolojin marked this pull request as ready for review July 3, 2024 08:44
@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (3d849e9) to head (f328151).
Report is 586 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7748       +/-   ##
==========================================
- Coverage   15.09%   0.00%   -15.10%     
==========================================
  Files        1967      74     -1893     
  Lines      135941    5138   -130803     
  Branches    42122     616    -41506     
==========================================
- Hits        20520       0    -20520     
+ Misses      92700    5138    -87562     
+ Partials    22721       0    -22721     
Flag Coverage Δ
differential 0.00% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito self-requested a review July 4, 2024 02:09
@technolojin technolojin merged commit 2acd484 into autowarefoundation:main Jul 4, 2024
40 of 41 checks passed
@technolojin technolojin deleted the refactor/namespace-occupancy_grid_map_outlier_filter branch July 11, 2024 05:34
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…tory structure (autowarefoundation#7748)

chore: update namespace and file structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…tory structure (autowarefoundation#7748)

chore: update namespace and file structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…tory structure (#7748)

chore: update namespace and file structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…tory structure (autowarefoundation#7748)

chore: update namespace and file structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants