Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_avoidance_planner): parameterize bounds search widths #807

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 25, 2022

Description

Just set bounds_search_widths as a ros parameter, which will be different depending on the vehicle size

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feature/parametrize-bounds-search-width branch from 0f6be8c to 31e1c39 Compare April 25, 2022 17:05
@takayuki5168 takayuki5168 marked this pull request as ready for review April 25, 2022 17:05
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 changed the title Feature/parametrize bounds search width feat(obstacle_avoidance_planner): parameterize bounds search widths Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #807 (73c6a9d) into main (7919b56) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #807      +/-   ##
========================================
- Coverage   9.63%   9.58%   -0.05%     
========================================
  Files        907     907              
  Lines      56544   56810     +266     
  Branches    6694    6694              
========================================
  Hits        5448    5448              
- Misses     46601   46867     +266     
  Partials    4495    4495              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.63% <0.00%> (ø) Carriedforward from 7919b56

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lude/obstacle_avoidance_planner/common_structs.hpp 0.00% <ø> (ø)
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 0.00% <0.00%> (ø)
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7919b56...73c6a9d. Read the comment docs.

@takayuki5168 takayuki5168 force-pushed the feature/parametrize-bounds-search-width branch 2 times, most recently from b96c5e8 to b6ce8c6 Compare April 26, 2022 10:35
@takayuki5168 takayuki5168 requested review from kosuke55 and removed request for TakaHoribe April 26, 2022 13:32
kosuke55
kosuke55 previously approved these changes Apr 27, 2022
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55
Copy link
Contributor

I also confirmed that the parameters are reflected with tier4/autoware_launch#295
ros2 param dump --print /planning/scenario_planning/lane_driving/motion_planning/obstacle_avoidance_planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 merged commit d9645f4 into autowarefoundation:main Apr 27, 2022
@takayuki5168 takayuki5168 deleted the feature/parametrize-bounds-search-width branch April 27, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants