-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): rename docker build
workflows
#4947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
6 tasks
mitsudome-r
reviewed
Jul 4, 2024
mitsudome-r
approved these changes
Jul 5, 2024
youtalk
added a commit
to youtalk/autoware
that referenced
this pull request
Jul 5, 2024
* feat(ci): save cache on `no-cuda` jobs and restore cache only on `cuda` jobs (autowarefoundation#4945) * feat(ci): rename `docker build` workflows (autowarefoundation#4947) * cache only on no-cuda Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * version up Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * version up Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename to health-check Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * refactor(ci): refactor `docker-build-and-push` action (autowarefoundation#4948) * cache only on no-cuda Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * version up Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * version up Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename to health-check Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * refactor action Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * remove old comment Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * revert free disk Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
pravinkmr26
pushed a commit
to pravinkmr26/autoware
that referenced
this pull request
Jul 15, 2024
* cache only on no-cuda Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * version up Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * version up Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename to health-check Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
no-cuda
jobs and restore cache only oncuda
jobs #4945As mentioned #4747, the workflows related to
docker build
is complex, and the names do not match their execution contents. Therefore, the names have been changed as follows.docker-build-and-push-main
->docker-build-and-push
build-main
->health-check
docker builds
on GitHub Actions have been speeding up, so I want to maketag:run-health-check
tag to run thehealth-check
on PR.Tests performed
#4948
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.