Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): rename docker build workflows #4947

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jul 4, 2024

Description

As mentioned #4747, the workflows related to docker build is complex, and the names do not match their execution contents. Therefore, the names have been changed as follows.

  • docker-build-and-push-main -> docker-build-and-push
  • build-main -> health-check

docker builds on GitHub Actions have been speeding up, so I want to make tag:run-health-check tag to run the health-check on PR.

Tests performed

#4948

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk changed the base branch from main to restore-only-on-cuda July 4, 2024 06:09
@youtalk youtalk marked this pull request as ready for review July 4, 2024 06:48
@youtalk youtalk requested review from xmfcx and mitsudome-r July 4, 2024 06:48
Base automatically changed from restore-only-on-cuda to main July 4, 2024 15:08
@youtalk youtalk requested a review from mitsudome-r July 5, 2024 06:34
@youtalk youtalk enabled auto-merge (squash) July 5, 2024 06:39
@youtalk youtalk merged commit 766c81b into main Jul 5, 2024
13 checks passed
@youtalk youtalk deleted the rename-docker-build-workflows branch July 5, 2024 06:46
youtalk added a commit to youtalk/autoware that referenced this pull request Jul 5, 2024
* feat(ci): save cache on `no-cuda` jobs and restore cache only on `cuda` jobs (autowarefoundation#4945)

* feat(ci): rename `docker build` workflows (autowarefoundation#4947)

* cache only on no-cuda

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* version up

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* version up

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* rename

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* rename

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* rename to health-check

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* refactor(ci): refactor `docker-build-and-push` action (autowarefoundation#4948)

* cache only on no-cuda

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* version up

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* version up

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* rename

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* rename

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* rename to health-check

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* refactor action

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* remove old comment

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* revert free disk

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
pravinkmr26 pushed a commit to pravinkmr26/autoware that referenced this pull request Jul 15, 2024
* cache only on no-cuda

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* version up

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* version up

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* rename

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* rename

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* rename to health-check

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk self-assigned this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants