-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_cruise_planner): improve stop and cruise behavior for cut-in & out #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brkay54
requested review from
takayuki5168,
rej55,
satoshi-ota,
shmpwk,
danielsanchezaran,
kyoichi-sugahara,
zulfaqar-azmi-t4,
go-sakayori,
kosuke55,
mkquda,
maxime-clem,
soblin and
yhisaki
as code owners
August 27, 2024 05:30
brkay54
force-pushed
the
ocr-improvement
branch
from
September 4, 2024 13:23
83339fd
to
b8b0061
Compare
brkay54
added a commit
that referenced
this pull request
Sep 9, 2024
brkay54
force-pushed
the
ocr-improvement
branch
from
September 18, 2024 18:29
b8b0061
to
28559b4
Compare
brkay54
added a commit
that referenced
this pull request
Sep 18, 2024
brkay54
force-pushed
the
ocr-improvement
branch
2 times, most recently
from
September 25, 2024 11:28
17be7d1
to
700c32c
Compare
brkay54
added a commit
that referenced
this pull request
Sep 30, 2024
…ut-in & out Signed-off-by: Berkay Karaman <berkay@leodrive.ai> #1142
brkay54
added a commit
that referenced
this pull request
Oct 1, 2024
…ut-in & out Signed-off-by: Berkay Karaman <berkay@leodrive.ai> #1142
…ut-in & out Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
brkay54
force-pushed
the
ocr-improvement
branch
from
October 3, 2024 00:58
700c32c
to
7c2a19c
Compare
yuki-takagi-66
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thank you
yuki-takagi-66
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Oct 10, 2024
…ut-in & out (autowarefoundation#1142) Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
yuki-takagi-66
added a commit
to tier4/autoware_launch
that referenced
this pull request
Oct 10, 2024
* feat(obstacle_cruise_planner): improve stop and cruise behavior for cut-in & out (autowarefoundation#1142) Signed-off-by: Berkay Karaman <berkay@leodrive.ai> * revert(obstacle_cruise): reduce using predicted paths to maintain conventional behavior (#621) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * revert(obstacle_cruisse): revert "fix(obstacle_cruise_planner): guarantee the stop margin (autowarefoundation#1076)" (autowarefoundation#1185) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> --------- Signed-off-by: Berkay Karaman <berkay@leodrive.ai> Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Co-authored-by: Berkay Karaman <brkay54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links
Tests performed
Notes for reviewers
Interface changes
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.