Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): improve stop and cruise behavior for cut-in & out #1142

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Aug 27, 2024

Description

Related links

Tests performed

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@brkay54 brkay54 self-assigned this Aug 27, 2024
@xmfcx xmfcx marked this pull request as draft September 3, 2024 15:46
@brkay54 brkay54 marked this pull request as ready for review September 4, 2024 13:29
brkay54 added a commit that referenced this pull request Sep 9, 2024
brkay54 added a commit that referenced this pull request Sep 18, 2024
@brkay54 brkay54 force-pushed the ocr-improvement branch 2 times, most recently from 17be7d1 to 700c32c Compare September 25, 2024 11:28
brkay54 added a commit that referenced this pull request Sep 30, 2024
…ut-in & out

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
#1142
brkay54 added a commit that referenced this pull request Oct 1, 2024
…ut-in & out

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
#1142
…ut-in & out

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you

@brkay54 brkay54 merged commit 80a387e into main Oct 8, 2024
18 checks passed
@brkay54 brkay54 deleted the ocr-improvement branch October 8, 2024 08:45
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Oct 10, 2024
…ut-in & out (autowarefoundation#1142)

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
yuki-takagi-66 added a commit to tier4/autoware_launch that referenced this pull request Oct 10, 2024
* feat(obstacle_cruise_planner): improve stop and cruise behavior for cut-in & out (autowarefoundation#1142)

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>

* revert(obstacle_cruise): reduce using predicted paths to maintain conventional behavior (#621)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* revert(obstacle_cruisse): revert "fix(obstacle_cruise_planner): guarantee the stop margin (autowarefoundation#1076)" (autowarefoundation#1185)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

---------

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Berkay Karaman <brkay54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants