Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: feat: change visualization of localization results from PoseHistory to PoseWithCovarianceHistory (#1164) #1179

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Sep 20, 2024

Description

Running with AWSIM Labs,

This is due to 1000 buffer size and the addition of about 1000 or 2000? new sphere markers due to this covariance visualization.

This PR reverts this change and restores RViz2 speed.

Tests performed

Tested with AWSIM Labs.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…istory to PoseWithCovarianceHistory (#1164)"

This reverts commit 593ad1f.
@github-actions github-actions bot added the component:ui User interface, user experience, graphical user interfaces. (auto-assigned) label Sep 20, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Sep 20, 2024

cc. @SaltUhey @SakodaShintaro

@xmfcx xmfcx self-assigned this Sep 20, 2024
@xmfcx xmfcx changed the title Revert "feat: change visualization of localization results from PoseHistory to PoseWithCovarianceHistory (#1164)" revert: feat: change visualization of localization results from PoseHistory to PoseWithCovarianceHistory (#1164) Sep 20, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. We don't need this feature right away, so I accept the revert.

I'll check the impact later.

@xmfcx xmfcx merged commit 5563b43 into main Sep 20, 2024
15 of 16 checks passed
@xmfcx xmfcx deleted the style/revert-rviz-ekf-pose-history branch September 20, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interface, user experience, graphical user interfaces. (auto-assigned) tag:run-build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants