Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pose_initializer): add new parameter for check error between initial pose and GNSS pose #1180

Conversation

RyuYamamoto
Copy link
Contributor

@RyuYamamoto RyuYamamoto commented Sep 26, 2024

Description

Related links

autowarefoundation/autoware.universe#8947

Tests performed

  • checkout autoware.universe to feat/initial_pose_check_with_gnss
  • Check that localization works correctly in logging_simulator.
  • Set pose_error_check_enabled to True and check that diagnostics (gnss_pose_error_2d, is_gnss_pose_error) are output. If set to False, gnss_pose_error_2d and is_gnss_pose_error are not output.

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Add new parameters.

Parameter Name Default Value Update Description
pose_error_threshold 5.0 The error threshold between GNSS and initial pose
pose_error_check_enabled false If true, check error between initial pose result and GNSS pose

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: RyuYamamoto <ryu.yamamoto@tier4.jp>
Signed-off-by: RyuYamamoto <ryu.yamamoto@tier4.jp>
@RyuYamamoto RyuYamamoto self-assigned this Sep 26, 2024
@RyuYamamoto RyuYamamoto added tag:run-build-and-test-differential component:localization Vehicle's position determination in its environment. (auto-assigned) labels Sep 26, 2024
@github-actions github-actions bot removed the component:localization Vehicle's position determination in its environment. (auto-assigned) label Sep 26, 2024
@RyuYamamoto RyuYamamoto marked this pull request as ready for review September 26, 2024 03:53
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyuYamamoto RyuYamamoto merged commit ebd55cc into autowarefoundation:main Sep 27, 2024
31 checks passed
@RyuYamamoto RyuYamamoto deleted the feat/initial_pose_check_with_gnss branch September 27, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants