Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes made on 27/03/17 during testing #138

Open
wants to merge 3 commits into
base: migrating-to-catkin
Choose a base branch
from

Conversation

pranaypratyush
Copy link

No description provided.

pranaypratyush and others added 2 commits March 27, 2017 00:25
…Info

- Added thruster mappings in "thrusterData6thruster.msg"
- Removed absolute_rpy_publisher.py
- Modified thruster.cpp to give 0.0 speed when no command published

TODO:
check control speed values on arduino

Signed-off-by: Shreyansh <shreyanshjain987@gmail.com>
@icyflame
Copy link
Member

icyflame commented Apr 2, 2017

@pranaypratyush waiting to merge this code till next testing session creates inconsistencies, if this code was working on the vehicle to some extent, merge within a few hours so everyone has a chance to comment if they want to. A week is more than enough time, anyway.

@pranaypratyush
Copy link
Author

I was assuming that the changes were 'hackish' and needs to be refined. Besides, the working code is on the bot already and committed, can't lose track. Aniket made the changes, since I didn't look at it later it's still unmerged.

- CREATED "thrusterData.msg"  "thrusterCmd.msg"     thruster ID,Speed…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants