-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cp-8368 historyservice #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's still a draft, but just wanted to leave my thoughts:
I liked how @gergelylovas got rid of different types of balances services and only left one BalancesService
. Can we do the same with the HistoryService
s?
For reference, here's the link to his BalancesService
:
We could essentially be left with just HistoryService
here that could load specific module for a given network and invoke getTransactionHistory()
on it.
good point, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!! 👏
I left some comments, but I think they'll be pretty quick to fix :)
src/pages/Wallet/components/History/components/ActivityCard/ActivityCardIcon.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also took it for a quick test and found filtering for Bridge
in activity tab doesn't seem to work. Posted suggestions for fixes below :)
Description
We want to use to fetch the transaction histories via the vm-modules.
Changes
Get rid of the old solutions and a unified history service fetch all the activities through the modules system.
Testing
Onboarding with a wallet which has p and / or x chain history. Try to go to all the chains and check the Activity, it should be almost the same as before except the ERC-1155 token transfers should show up.
Screenshots:
Screen.Recording.2024-09-12.at.18.30.10.mov
Checklist for the author
Tick each of them when done or if not applicable.