Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: perform eth_sendTransaction via EVM module #51

Merged
merged 10 commits into from
Oct 10, 2024
Merged

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Sep 20, 2024

  • CP-9159
  • + migrate eth_sendTransaction to be performed via EVM Module

Changes

  • Starts using the updateTx callback provided by VM Modules for updating transaction fee configs / spend limits (see related PR above)
  • Removes eth_sendTransaction handler and some of the related files so that those requests are performed using the EvmModule
    • Also removes the SignTransaction.tsx file / route & related files
  • Updates useFeeCustomizer hook to also handle EVM fees
  • Updates approval screen components to the new displayData schema so they can be used on GenericApprovalScreen

Testing

Basically a full regression on EVM features is needed:

  • Send
  • Bridge
  • Swap
    • all of the above features but initiated by Core Web
  • Send NFT
  • dApp integrations (i.e. liquidity pool on TraderJoe.xyz)
    • make sure token spend approvals work as they used to
    • make sure LBT (Liquidity Book Tokens) collapse in an accordion
  • Verify that the chainId parameter in eth_sendTransaction payload works as it used to
    • no cross-environment transaction execution allowed (no mainnet execution while UI is on testnet or vice-versa)
    • transactions on custom networks are only allowed if the custom network is also active in the UI

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

Copy link
Contributor

@gergelylovas gergelylovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job nice to see the update tx flow in action! Only a few small comments.

Copy link
Contributor

@vvava vvava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧜‍♀️

@meeh0w meeh0w merged commit f779698 into main Oct 10, 2024
5 checks passed
@meeh0w meeh0w deleted the refactor/evm-rpcs branch October 10, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants