feat: CP-9360 wallet selector rework #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeh0w
reviewed
Oct 18, 2024
meeh0w
approved these changes
Oct 29, 2024
| @@ -4,4 +4,7 @@ export enum WalletExtensionType { | |||
| UNKNOWN = 'UNKNOWN', | |||
| RABBY = 'RABBY', | |||
| COINBASE = 'COINBASE', | |||
| PHANTOM = 'PHANTOM', | |||
There was a problem hiding this comment.
I can't really make Phantom appear, I guess they don't announce themselves? 🤔
There was a problem hiding this comment.
I'm checking that when I get home later today.
There was a problem hiding this comment.
It seems it can work :D
meeh0w
requested changes
Oct 31, 2024
bferenc
previously approved these changes
Nov 4, 2024
meeh0w
previously approved these changes
Nov 4, 2024
bferenc
previously approved these changes
Nov 4, 2024
meeh0w
approved these changes
Nov 4, 2024
bferenc
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our old method how we stored the different Wallet Extension has been deprecated we could not detect a lot of them and made the whole thing messy.
Changes
Now we are using EICP-6963 to detect them and add them to the providers list. We have an updated UI as well.
Testing
Install multiple extensions -> go to the playground and try to connect
Screenshots:
Screen.Recording.2024-10-17.at.20.02.45.mov
Checklist for the author
Tick each of them when done or if not applicable.