fix: collectibles view quirks #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeh0w
commented
Oct 18, 2024
Comment on lines
+152
to
+153
| // We used to (wrongly) index by address only. | ||
| const isHidden = (visibility[key] ?? visibility[nft.address]) === false; |
There was a problem hiding this comment.
Having a schema upgrade would be the best for this, but I don't think it's worth the effort (+ we don't have the tokenId in the current storage data anyway). After toggling once it "fixes itself" for all NFTs sharing a given address.
bferenc
approved these changes
Oct 21, 2024
zsuninnyi
approved these changes
Oct 22, 2024
vvava
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no ticket, fixes for issues found during blue build testing (+ some additional quirks)
Fixed issues
addressonly, but it's possible to have multiple NFTs of the same address but differenttokenId-- this resulted in hiding entire batches of NFTs when trying to hide a specific NFT)Testing
Go to the Collectibles tab and play around
Checklist for the author