feat: add default tokens to swap #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeh0w
requested changes
Oct 29, 2024
src/pages/Swap/Swap.tsx
Outdated
Comment on lines
118
to
120
| token: AVAX_TOKEN, | ||
| fromToken: AVAX_TOKEN, | ||
| toToken: USDC_TOKEN, |
There was a problem hiding this comment.
Not related to this PR, but the fact we need to provide token, fromToken and toToken here breaks my brain. 🤯 Why three values!? 😂
src/pages/Swap/Swap.tsx
Outdated
| @@ -104,6 +105,30 @@ export function Swap() { | |||
| destAmount, | |||
| } = useSwapStateFunctions(); | |||
|
|
|||
| useEffect(() => { | |||
| if (!selectedFromToken && !selectedToToken) { | |||
There was a problem hiding this comment.
This check alone does not quite work, tokens are not restored when I close and re-open extension.
Prod build:
Screen.Recording.2024-10-29.at.09.05.07.mov
This branch:
Screen.Recording.2024-10-29.at.09.04.21.mov
meeh0w
requested changes
Oct 31, 2024
Yeah, something is wrong there, I'm fixing it |
bferenc
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to add default tokens to the Swap page
Changes
Set the AVAX and USDC tokens as default transaction pairs.
Testing
Go to the swap page -> you should see the AVAX in the
fromand the USDC in thetofield -> swap should work as beforeScreenshots:
Screen.Recording.2024-10-28.at.20.06.02.mov
Checklist for the author
Tick each of them when done or if not applicable.