fix: keystone approvals, bridge amount too low, spend approval dollar value #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeh0w
commented
Nov 6, 2024
| @@ -212,7 +212,7 @@ export const BridgeForm = ({ | |||
| const [neededGas, setNeededGas] = useState(0n); | |||
|
|
|||
| useEffect(() => { | |||
| if (minimum && amount.lt(minimum)) { | |||
| if (minimum && amount.gt(0) && amount.lt(minimum)) { | |||
There was a problem hiding this comment.
Don't show the "Amount is too low" error if amount is 0
meeh0w
commented
Nov 6, 2024
| return await this.#walletService.sign( | ||
| signingData.data, | ||
| network, | ||
| action.tabId |
There was a problem hiding this comment.
Pass tabId, so the signature request can later be paired with the window that initiated the request
meeh0w
commented
Nov 6, 2024
| (diffItemValue as TokenUnit).toDisplay({ asNumber: true }) * | ||
| Number(approval.usdPrice) | ||
| ), | ||
| usdPrice: approval.usdPrice, |
There was a problem hiding this comment.
This was being multiplied unnecessarily - I thought usdPrice is the price of a single token here, but it's the USD value of the whole approval.
vvava
approved these changes
Nov 6, 2024
bferenc
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes these issues: