QA New Test Balance after hiding and showing token #2062
+313
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Eunji Song <32075932+eunjisong@users.noreply.github.com>
eunjisong
requested review from
Any2suited66,
neven-s,
atn4z7,
ruijialin-avalabs and
onghwan
as code owners
Any2suited66
reviewed
Nov 7, 2024
Comment on lines
+42
to
+70
| async hideToken(token: string) { | ||
| await commonElsPage.typeSearchBar(token) | ||
| // TryCatch Phrase is for test requirment | ||
| try { | ||
| await Action.waitForElement(by.id(`${token}_blocked`)) | ||
| await Action.tap(by.id(`${token}_blocked`)) | ||
| console.log("Display the token if it's already hidden") | ||
| } catch (e) { | ||
| console.log("It's already displayed on token list") | ||
| } | ||
| // Hide the token | ||
| await Action.tap(by.id(`${token}_displayed`)) | ||
| await commonElsPage.goBack() | ||
| } | ||
|
|
||
| async showToken(token: string) { | ||
| await commonElsPage.typeSearchBar(token) | ||
| // TryCatch Phrase is for test requirment | ||
| try { | ||
| await Action.waitForElement(by.id(`${token}_display`)) | ||
| await Action.tap(by.id(`${token}_blocked`)) | ||
| console.log("Block the token if it's already displayed") | ||
| } catch (e) { | ||
| console.log("It's already blocked") | ||
| } | ||
| // Display the token | ||
| await Action.tap(by.id(`${token}_blocked`)) | ||
| await commonElsPage.goBack() | ||
| } |
There was a problem hiding this comment.
These methods are almost the same and should be combined into one. Something like this?
async showToken(token: string, tokenStatus: "blocked") {
await commonElsPage.typeSearchBar(token)
// TryCatch Phrase is for test requirement
try {
await Action.waitForElement(by.id(`${token}_${tokenStatus}`))
await Action.tap(by.id(`${token}_${tokenStatus}`))
console.log("Block the token if it's already displayed")
} catch (e) {
console.log("It's already blocked")
}
// Display the token
await Action.tap(by.id(`${token}_${tokenStatus}`))
await commonElsPage.goBack()
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Please check all that apply (if applicable)