get upgrade configs from context #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
commented
Aug 9, 2024
Can you please clarify? The existing automated tests, or something else? |
darioush
approved these changes
Aug 13, 2024
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
* get upgrade configs from context * fix chainIDs * fix avago version * commment out override * Remove comment out code * use network ID rather than chain ID * update avago to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
AvalancheGo added upgrade config to snow context
Related AvalancheGo PR ava-labs/avalanchego#3283
However we don't really need to change anything in Coreth since upgrades were written to chainConfig in genesis thus we have other source of information rather than upgrade configs in avalanchego/snow.Context.
How this works
How this was tested
e2e should mostly cover this. I also did a local network testing with avalanchego to test out if network upgrades are passed correctly (but we don't actually use them)