Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade configs use ctx #635

Merged
merged 25 commits into from
Aug 20, 2024
Merged

Upgrade configs use ctx #635

merged 25 commits into from
Aug 20, 2024

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Aug 14, 2024

Why this should be merged

How this works

How this was tested

params/network_upgrades.go Outdated Show resolved Hide resolved
@ceyonur ceyonur marked this pull request as ready for review August 16, 2024 14:58
@ceyonur ceyonur requested a review from darioush as a code owner August 16, 2024 14:58
@darioush darioush merged commit 5fce143 into master Aug 20, 2024
8 checks passed
@darioush darioush deleted the upgrade-configs-use-ctx branch August 20, 2024 22:32
oxbee pushed a commit to taurusgroup/coreth that referenced this pull request Nov 6, 2024
* get upgrade configs from context

* fix chainIDs

* fix avago version

* commment out override

* Remove comment out code

* use network ID rather than chain ID

* refactor params config

* update avago

* rename

* fix runtime networks

* override netowrk upgrades from context

* Update params/network_upgrades.go

Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>

* remove comment

* use chainID copy

* bump avago

* remove debug logs

* update avago version

---------

Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants