fix: set eth upgrades in backwards compatible way #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
reviewed
Oct 3, 2024
darioush
force-pushed
the
fix-setting-eth-upgrades
branch
from
f735c1e to
4dd0e87
Compare
ceyonur
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Current code does not function for mainnet/fuji.
When running a node with those chain IDs, the existing chain config will not have berlin/london & shanghai.
Therefore, we should apply the SetEthUpgrade anytime we unmarshal the config, including in the genesis,
prior to checking for compatibility.
How this works
As explained.
How this was tested
[x] Added UT
[x] Tested by using database from running node, then continuing with this version (fuji)