-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gas optimizations when importing events #67
Draft
iFrostizz
wants to merge
26
commits into
main
Choose a base branch
from
use_less_gas
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch creates a deep copy of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breakdown of the changes: https://docs.google.com/document/d/12MuoEeECCWr3jNgYAZJrSCXv3tkYoFKO_DLHPCLU2EE/edit?usp=sharing
In order to import an event, it should be proven that this one is part of the final tip.
The first step is to get a block hash from the source chain and check that the provided block hash (which is calculated from the keccak256 hash of the rlp header) equals the (last?) queried one. By the way, if
getVerifiedWarpBlockHash(0)
really returns the last block hash, that means that it would not be possible to keep up with fast blocks if the relayer didn't sent the transaction that imports the log fast enough (need to investigate).Then the block header is RLP-decoded (only the top level so it should be pretty cheap) and the receipt root is taken to verify the receipts from the MPT and get the receipt in order to RLP-decode the log.
By only RLP-decoding the needed information (specific log from index), 30k gas are shaved from the
importEvent
function from thetestImportEvent
test.Please find the following flamegraph generated by an experimental branch adding the
--flamegraph
flag toforge test
edit:
almost saved 100k from the call to
importEvent