Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto cleanup #1134

Closed
wants to merge 6 commits into from
+116 −54
Closed

Auto cleanup #1134

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ac8019
Update deploy.devnet.sh
sukantoraymond Jul 9, 2024
c9a2d12
Update deploy.devnet.sh
sukantoraymond Jul 12, 2024
b67d964
Merge branch 'vryx-poc' into auto-cleanup
sukantoraymond Jul 12, 2024
c8edd54
Update deploy.devnet.sh
sukantoraymond Jul 12, 2024
c01b9a3
auto cleanup
sukantoraymond Jul 12, 2024
0a8ac9b
Update deploy.devnet.sh
sukantoraymond Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/morpheusvm/scripts/deploy.devnet.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ EOF
# Setup devnet
CLUSTER="vryx-$(date +%s)"
function cleanup {
echo -e "\n\n${RED}run this command to destroy the devnet:${NC} ${TMPDIR}/avalanche node destroy ${CLUSTER}\n"
echo -e "\n\n${RED}destroying the devnet, running:${NC} ${TMPDIR}/avalanche node destroy ${CLUSTER}\n"
${TMPDIR}/avalanche node destroy ${CLUSTER} -y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this terminate the whole network when the script completes as well, whereas it should be left running in that case and cleaned up if the script fails or is cancelled part way through?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1136

}
trap cleanup EXIT
# List of supported instances in each AWS region: https://docs.aws.amazon.com/ec2/latest/instancetypes/ec2-instance-regions.html
Expand Down
Loading