Remove Permissions From Fetcher #1839
Merged
+30
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodrigoVillar
requested review from
aaronbuchwald and
joshua-kim
as code owners
state/keys.go
Outdated
Comment on lines
64
to
65
| // Strip returns the database keys of k | ||
| func (k Keys) Strip() []string { |
There was a problem hiding this comment.
Could we rename this to either Keys(), KeysWithoutPermissions(), or WithoutPermissions() ?
There was a problem hiding this comment.
Will rename to WithoutPermissions()
Signed-off-by: aaronbuchwald <aaron.buchwald56@gmail.com>
aaronbuchwald
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes permissions from
Fetcherby having it take in a slice of strings (i.e. database keys) instead ofstate.Keys.This PR also modifies the
Fetchertests to natively use database keys instead of state keys.