Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove params dependency on modules #1261

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

refactor: remove params dependency on modules #1261

wants to merge 27 commits into from

Commits on Jul 29, 2024

  1. experiment: lazy-init precompiles in ChainConfig

    @ARR4N
    ARR4N committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    af8ab3e View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. refactor: move modules-dependent code out of params (only builds;… 

    … does not work)
    @ARR4N
    ARR4N committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7f39a4c View commit details
    Browse the repository at this point in the history

  2. fix: change ChainConfig.Fn() method calls to modules.Fn(ChainConfig)

    @ARR4N
    ARR4N committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6acef2a View commit details
    Browse the repository at this point in the history

  3. refactor: HACKY! ./params/... and ./precompile/... tests passing

    @ARR4N
    ARR4N committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    8d9a7b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. refactor: make params.ChainConfig.Rules() self-contained

    @ARR4N
    ARR4N committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    574f91d View commit details
    Browse the repository at this point in the history

  2. chore: remove unnecessary nil check

    @ARR4N
    ARR4N committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    2722fb8 View commit details
    Browse the repository at this point in the history

  3. feat: paramsjson package for JSON unmarshalling params.<T> that d… 

    …epend on `modules`
    @ARR4N
    ARR4N committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    87b3b8f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into arr4n/circular-dep-types-precompiles

    @ARR4N
    ARR4N committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    ff2f78a View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. chore: revert change to params.TestRules

    @ARR4N
    ARR4N committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    3899608 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. refactor: inject paramsjson.Unmarshal() as UnmarshalJSON() method… 

    …s in `params`
    @ARR4N
    ARR4N committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    1f587b4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into arr4n/circular-dep-types-precompiles

    @ARR4N
    ARR4N committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    9b40ffd View commit details
    Browse the repository at this point in the history

  3. refactor: use regular json.Unmarshal() and blank `import _ .../para… 

    …msjson"` instead
    @ARR4N
    ARR4N committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    e21cf4b View commit details
    Browse the repository at this point in the history

  4. fix: _ import paramsjson in tests

    @ARR4N
    ARR4N committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    ae55c97 View commit details
    Browse the repository at this point in the history

  5. chore: blank _ import paramsjson in plugin/main.go

    @ARR4N
    ARR4N committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    8207300 View commit details
    Browse the repository at this point in the history

  6. chore: blank _ import paramsjson in tests/utils/subnet.go

    @ARR4N
    ARR4N committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    143317d View commit details
    Browse the repository at this point in the history

  7. refactor: precompileconfig.Config.Address() method instead of map o… 

    …f precompile addresses
    @ARR4N
    ARR4N committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    b19cc5c View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. refactor: move params.ChainConfig methods back from modules package

    @ARR4N
    ARR4N committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    03c5f9d View commit details
    Browse the repository at this point in the history

  2. refactor: move params.ChainConfig methods to their original locatio… 

    …ns to minimise diff
    @ARR4N
    ARR4N committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    29aa763 View commit details
    Browse the repository at this point in the history

  3. chore: revert cosmetic changes

    @ARR4N
    ARR4N committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    afce466 View commit details
    Browse the repository at this point in the history

  4. chore: revert as many changes as possible in `params.ChainConfig.Rule… 

    …s()`
    @ARR4N
    ARR4N committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ba12b54 View commit details
    Browse the repository at this point in the history

  5. chore: add Address() method on test-double `precompileconfig.Config… 

    …` impls
    @ARR4N
    ARR4N committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b55bba4 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. fix: all unit tests passing locally

    @ARR4N
    ARR4N committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    eb4e226 View commit details
    Browse the repository at this point in the history

  2. chore: update copyright years to keep linter happy

    @ARR4N
    ARR4N committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    b15507b View commit details
    Browse the repository at this point in the history

  3. refactor: paramsjson misc (see full message) 

    * Stop exporting any identifiers, relying solely on `_` importing
* Split out `Unmarshal()` type switch into specific functions
    @ARR4N
    ARR4N committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    6a7803e View commit details
    Browse the repository at this point in the history

  4. refactor: add Must prefix and panics to `params.RegisterJSONUnmarsh… 

    …alers()`
    @ARR4N
    ARR4N committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0aa0922 View commit details
    Browse the repository at this point in the history

  5. test: params.UpgradeConfig comprehensive testing

    @ARR4N
    ARR4N committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    30e45f4 View commit details
    Browse the repository at this point in the history

  6. chore: remove unnecessary variable declaration

    @ARR4N
    ARR4N committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8d7c002 View commit details
    Browse the repository at this point in the history