Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 new metric attributes added #286

Merged
merged 5 commits into from
Sep 19, 2023
Merged

4 new metric attributes added #286

merged 5 commits into from
Sep 19, 2023

Conversation

sh3ll3x3c
Copy link
Member

Added 4 new metric attributes:

  • ip -> IP address of the light client taken from it's external multi-address
  • job -> set to avail_light_client; job is a default OT metric attribute for every metric sent
  • version -> Light Client version retrieved from CARGO_PKG_VERSION env variable
  • role -> type of the client: crawler, app, bootstrap, relay or lightclient

@sh3ll3x3c sh3ll3x3c marked this pull request as ready for review September 18, 2023 16:23
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (b1dd69d) 27.12% compared to head (cf792fb) 27.07%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   27.12%   27.07%   -0.06%     
==========================================
  Files          22       22              
  Lines       10599    10620      +21     
==========================================
  Hits         2875     2875              
- Misses       7724     7745      +21     
Files Changed Coverage Δ
src/network/event_loop.rs 0.00% <0.00%> (ø)
src/network/mod.rs 0.00% <0.00%> (ø)
src/telemetry/mod.rs 100.00% <ø> (ø)
src/telemetry/otlp.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sh3ll3x3c sh3ll3x3c merged commit dcc8b5e into main Sep 19, 2023
1 check passed
@sh3ll3x3c sh3ll3x3c deleted the additional-metric-attributes branch September 19, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants