-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add power-assert enabled t.assert() assertion; remove from others #2056
Conversation
because true is no longer power-assertion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @eemed. Will you make the PR for https://github.com/avajs/babel-preset-transform-test-files/blob/master/espower-patterns.json?
We'll have to update the documentation as well.
To update the reporter tests you can run UPDATE_REPORTER_LOG=1 npx tap --no-cov test/reporters/*.js
.
and fix typo
Updated tests and used .assert() in the test case. PR for babel-preset-transform-files is here. |
Looks great @eemed. Would you want to have a stab at updating the documentation? |
I can take a look. Do I just commit doc updates to this pr aswell? |
Yep! |
I'm not sure if there's more updating to be done. I tried to look through all the files but didn't find anything else. |
@eemed I've pushed some documentation updates, let me know what you think. Let's hold off merging until we can address avajs/eslint-plugin-ava#218. Perhaps you'd like to tackle that one too? 😄 |
I can take a look at it next weekend. |
Initial for #1808 . I still have those 3 failing tests but could you @novemberborn take a look at this first.
I moved these functions away from enhanced assert.
Added a new function t.assert() to enhanced assert and copied over the t.truthy() tests.
Then I tried to update the tests that kept failing. I also updated the patterns in babel-preset-transform-test-files.