Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add power-assert enabled t.assert() assertion; remove from others #2056

Merged
merged 13 commits into from
Mar 24, 2019
Merged

Add power-assert enabled t.assert() assertion; remove from others #2056

merged 13 commits into from
Mar 24, 2019

Conversation

eemed
Copy link
Contributor

@eemed eemed commented Mar 2, 2019

Initial for #1808 . I still have those 3 failing tests but could you @novemberborn take a look at this first.
I moved these functions away from enhanced assert.

  • t.truthy()
  • t.falsy()
  • t.true()
  • t.false()
  • t.regex()
  • t.notRegex()

Added a new function t.assert() to enhanced assert and copied over the t.truthy() tests.
Then I tried to update the tests that kept failing. I also updated the patterns in babel-preset-transform-test-files.

Copy link
Member

@novemberborn novemberborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @eemed. Will you make the PR for https://github.com/avajs/babel-preset-transform-test-files/blob/master/espower-patterns.json?

We'll have to update the documentation as well.

To update the reporter tests you can run UPDATE_REPORTER_LOG=1 npx tap --no-cov test/reporters/*.js.

test/assert.js Outdated Show resolved Hide resolved
test/fixture/enhanced-assertion-formatting.js Outdated Show resolved Hide resolved
@eemed
Copy link
Contributor Author

eemed commented Mar 3, 2019

Updated tests and used .assert() in the test case. PR for babel-preset-transform-files is here.

@novemberborn
Copy link
Member

Looks great @eemed. Would you want to have a stab at updating the documentation?

@eemed
Copy link
Contributor Author

eemed commented Mar 6, 2019

I can take a look. Do I just commit doc updates to this pr aswell?

@novemberborn
Copy link
Member

Do I just commit doc updates to this pr aswell?

Yep!

@eemed
Copy link
Contributor Author

eemed commented Mar 7, 2019

I'm not sure if there's more updating to be done. I tried to look through all the files but didn't find anything else.

@novemberborn novemberborn changed the title Power assert Add power-assert enabled t.assert() assertion; remove from others Mar 17, 2019
@novemberborn
Copy link
Member

@eemed I've pushed some documentation updates, let me know what you think.

Let's hold off merging until we can address avajs/eslint-plugin-ava#218. Perhaps you'd like to tackle that one too? 😄

@eemed
Copy link
Contributor Author

eemed commented Mar 18, 2019

I can take a look at it next weekend.

@novemberborn novemberborn merged commit 9406470 into avajs:master Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants