Clean up runner #239
Merged
Clean up runner #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| .catch(noop) | ||
| .then(function () { | ||
| stats.testCount = tests.only.length ? tests.only.length : stats.testCount; | ||
| stats.testCount = hasOnlyTests ? tests.only.length : stats.testCount; |
There was a problem hiding this comment.
What about...
stats.testCount = tests.only.length || stats.testCount;There was a problem hiding this comment.
It's the small things ✨
vadimdemedes
force-pushed
the
cleanup-runner
branch
from
c909e02 to
d6699d1
Compare
|
@jamestalmage Node.js 0.10 seems to be failing again on Windows :( https://ci.appveyor.com/project/sindresorhus/ava/build/job/vrwhv5konnjgylcc |
|
Yes, failure is different now. "Missing plan". In TAP, the plan line can be emitted at the beginning or end. If it is the end, we already know forked processes often drop a line or two of IO from the end on Windows (especially Node 0.10). It could be something else entirely, but that is my initial suspicion. |
|
@jamestalmage Yeah, my suspicion too. Might be relevant: nodejs/node#3670 |
|
Yes. Looks very relevant. Perhaps we need to avoid explicitly ending the process unless we have to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup of
lib/runner.js