Correct issue #16 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… PMS5003ST. Also adds offsets to temperature and humidity to correct sensor's deviation.
avaldebe
reviewed
Nov 25, 2020
src/PMserial.h
Outdated
Comment on lines
134
to
137
| void set_rhum_offset(float offset) { rhum_offset = offset; }; | ||
| void set_temp_offset(float offset) { temp_offset = offset; }; | ||
| float get_rhum_offset() { return rhum_offset; }; | ||
| float get_temp_offset() { return temp_offset; }; |
There was a problem hiding this comment.
I think that this methods could be inline-ed
Also, I see the need for set_rhum_offset/set_temp_offset but I'm not so sure about get_rhum_offset/get_temp_offset
|
Hi @fmatray Thanks for your PR. I really appreciate the help with testing and patching. I have 2 requests before merging your PR:
Thanks again, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct issue #16