Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delay based on error #35

Merged
merged 4 commits into from
Oct 13, 2020
Merged

delay based on error #35

merged 4 commits into from
Oct 13, 2020

Conversation

JaSei
Copy link
Collaborator

@JaSei JaSei commented Oct 9, 2020 •
edited
Loading

#33

@JaSei JaSei mentioned this pull request Oct 9, 2020
Closed
sranka
sranka reviewed Oct 9, 2020
View reviewed changes
Copy link
Contributor

@sranka sranka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it allows what I was originally looking for.

README.md Outdated Show resolved Hide resolved
options.go Show resolved Hide resolved
examples/delay_based_on_error_test.go Outdated Show resolved Hide resolved
retry.go Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 10, 2020 •
edited
Loading

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files           2        2           
  Lines          91       91           
=======================================
  Hits           90       90           
  Misses          1        1
Impacted Files Coverage Δ
options.go 100.00% <100.00%> (ø)
retry.go 98.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0c2cc...821cbc6. Read the comment docs.

use httptest instead of real http call
7062aab 
remove ParseRetryAfter header + link to module which does it
@JaSei
Copy link
Collaborator Author

JaSei commented Oct 10, 2020

Thanks, @sranka for your all hints.

@JaSei JaSei merged commit abbd4ed into master Oct 13, 2020
@JaSei JaSei deleted the delay_function_based_on_error branch October 13, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sranka sranka sranka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaSei @codecov-io @sranka