Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moves exported default values to function #44

Merged
merged 2 commits into from
Jun 1, 2021
Merged

moves exported default values to function #44

merged 2 commits into from
Jun 1, 2021

Conversation

Noroth
Copy link

@Noroth Noroth commented May 12, 2021

fixes #40
I bumped the version to 3.1.0 and ran the following make commands:

  • cover
  • fmt
  • release

I hope I didn't forget something, otherwise let me know

@codecov-commenter
Copy link

Codecov Report

Merging #44 (b6d0474) into master (7096610) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   98.90%   98.86%   -0.04%     
==========================================
  Files           2        2              
  Lines          91       88       -3     
==========================================
- Hits           90       87       -3     
  Misses          1        1              
Impacted Files Coverage Δ
retry.go 98.11% <100.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7096610...b6d0474. Read the comment docs.

@JaSei
Copy link
Collaborator

JaSei commented Jun 1, 2021

Thanks for your PR

@JaSei JaSei merged commit d8dc92d into avast:master Jun 1, 2021
@Noroth Noroth deleted the feature/move-exported-values-to-default-function branch June 1, 2021 09:43
@ghost
Copy link

ghost commented Jun 1, 2021

Good move, i must say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Exported default variables should be constants
3 participants