fix!: Context cancel add to errors #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `retry.Context(ctx)` where the cancelled context stops the retry loop, add the context to the error log - Unless last error only is set. This allows for consumers to access the errors that have occurred throughout the retry loop easily.
JaSei
approved these changes
Nov 18, 2021
|
@56KBs thanks to your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
retry.Context(ctx)where the cancelled context stops the retry loop, add the context to the error log - Unless last error only is set.This allows for consumers to access the errors that have occurred throughout the retry loop easily.
Technically this is a breaking change as previously it would return the error from the context by default, however now it will return a
retry.Errorby default.Fixes #51