fix: Wrong use of Micrometer metrics #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: New sst-cats-effect subproject with F.time method
That's an unfortunate development. Was that a particular rule? Is there an error message from logs somewhere to investigate? |
|
It's this bug: scalacenter/scalafix#1125 It was encountered not only in SST but also in our internal projects. |
hanny24
reviewed
May 19, 2020
cats-effect/src/main/scala/com/avast/sst/catseffect/package.scala
Outdated
Show resolved
Hide resolved
jendakol
approved these changes
May 19, 2020
cats-effect/src/main/scala/com/avast/sst/catseffect/syntax/TimeSyntax.scala
Outdated
Show resolved
Hide resolved
hanny24
reviewed
May 20, 2020
|
Yes. I've separated it into a standalone function. |
jakubjanecek
removed
the
mergify-wait
hanny24
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: New sst-cats-effect subproject with F.time method
I had a discussion with core Micrometer contributor who pointed our wrong use of the library so I am fixing it with this PR.
I also encountered a problem with Scalafix and Scala 2.13 (I don't know why it hasn't happened before) so I am also disabling Scalafix temporarily.
And the last thing is new
sst-cats-effectsubproject which adds one utility method on top ofFwhich allows you to measure and record time it took.