Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow local and persistent mockup handle #44

Merged
merged 5 commits into from
Apr 13, 2024
Merged

Allow local and persistent mockup handle #44

merged 5 commits into from
Apr 13, 2024

Conversation

theHolgi
Copy link
Contributor

Fixes #41

@theHolgi theHolgi marked this pull request as ready for review August 19, 2023 18:53
@theHolgi theHolgi force-pushed the feature/41-durable_mockup branch 2 times, most recently from c86425f to c8d1b22 Compare August 19, 2023 20:57
@theHolgi theHolgi added enhancement New feature or request READY labels Aug 19, 2023
@theHolgi theHolgi added the help wanted Extra attention is needed label Mar 20, 2024
@theHolgi
Copy link
Contributor Author

@xxthunder Can someone with access to weird operating systems tell how the clang module is called there?

@xxthunder
Copy link
Member

Hi Holgi, I will check your feature branch on the weird OS tomorrow. I did not have a look into hammocking for a while. I will come back to you.

CU,
Karsten

@xxthunder xxthunder self-requested a review March 21, 2024 19:12
@theHolgi theHolgi removed the help wanted Extra attention is needed label Mar 22, 2024
@theHolgi
Copy link
Contributor Author

Problem solved. Normal review requested

xxthunder
xxthunder reviewed Apr 4, 2024
View reviewed changes
hammocking/hammocking.py Outdated Show resolved Hide resolved
xxthunder
xxthunder requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@xxthunder xxthunder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment.

Another remark: for a clean history in the future please avoid merging develop into feature branches but please rebase your feature branch onto develop. Thanks!

@theHolgi theHolgi force-pushed the feature/41-durable_mockup branch from 26a8d30 to 18beda0 Compare April 4, 2024 21:05
@theHolgi
Copy link
Contributor Author

theHolgi commented Apr 4, 2024

Clean history.

@theHolgi theHolgi requested a review from xxthunder April 4, 2024 21:53
xxthunder
xxthunder reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@xxthunder xxthunder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my questions in the examplary test.cc

@xxthunder
Copy link
Member

@theHolgi See my proposal and comments.

xxthunder
xxthunder requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@xxthunder xxthunder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theHolgi If you like my naming proposals, please adapt the PR accordingly. If you want to do a breaking change with a new major version, I am also fine with it. The one updating to the latest release must adapt her/his tests anyhow.

xxthunder
xxthunder approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@xxthunder xxthunder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🌔 🎸

@xxthunder xxthunder merged commit 304d3d3 into develop Apr 13, 2024
2 checks passed
@xxthunder xxthunder deleted the feature/41-durable_mockup branch April 13, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxthunder xxthunder xxthunder approved these changes

Assignees

@theHolgi theHolgi

Labels
enhancement New feature or request READY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide explicit disposal of mockup object
2 participants
@theHolgi @xxthunder