Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to go to Summary page #1439

Closed
Tracked by #1421
BEULAHEVANJALIN opened this issue Jun 25, 2024 · 2 comments
Closed
Tracked by #1421

Unable to go to Summary page #1439

BEULAHEVANJALIN opened this issue Jun 25, 2024 · 2 comments
Assignees

Comments

@BEULAHEVANJALIN
Copy link

BEULAHEVANJALIN commented Jun 25, 2024

https://avni.freshdesk.com/a/tickets/4212

Describe the bug
When clicking the summary button in an encounter form (dispatch receipt encounter in Goonj), the RuleService continuously tries to load rules (such as ViewFilter, Validation, Decision) for the dispatch receipt form 57bb2d3a-f8a5-4405-8d2c-514456e91533, leading to an infinite loop.

Screen Recording 2024-06-25 at 5 45 39 PM
https://drive.google.com/file/d/1kRN9QYB9dpfIMSNo8rwYiYdKKRJ0OiJb/view?usp=drive_link

Expected behavior
The rules associated with the dispatch receipt form should load once and then allow the user to proceed to the summary page.

Additional context
Have tried in 8.1 and 7.0
I also tried it in dummy org where it worked fine.
Also tested it with different concept types like question group with repeatable fields. It's working fine there.

Error message

DEBUG  [10:47:09:823] [IndividualEncounterView::AC][Debug] Dispatching action: "EA.SUMMARY_PAGE"
DEBUG  [10:47:09:834] [RuleService][Debug] Getting Rules of Type ViewFilter for Form - Dispatch receipt form 57bb2d3a-f8a5-4405-8d2c-514456e91533
DEBUG  [10:47:09:931] [RuleService][Debug] Getting Rules of Type ViewFilter for Form - Dispatch receipt form 57bb2d3a-f8a5-4405-8d2c-514456e91533
DEBUG  [10:47:10:000] [RuleService][Debug] Getting Rules of Type ViewFilter for Form - Dispatch receipt form 57bb2d3a-f8a5-4405-8d2c-514456e91533
DEBUG  [10:47:10:002] [No form elements here. Moving to next screen][Debug] undefined
DEBUG  [10:47:10:004] [RuleService][Debug] Getting Rules of Type ViewFilter for Form - Dispatch receipt form 57bb2d3a-f8a5-4405-8d2c-514456e91533
DEBUG  [10:47:10:093] [RuleService][Debug] Getting Rules of Type Validation for Form - Dispatch receipt form 57bb2d3a-f8a5-4405-8d2c-514456e91533
DEBUG  [10:47:10:095] [RuleService][Debug] Getting Rules of Type Decision for Form - Dispatch receipt form 57bb2d3a-f8a5-4405-8d2c-514456e91533
DEBUG  [10:47:10:095] [RuleEvaluationService][Debug] {"enrolmentDecisions":[],"encounterDecisions":[],"registrationDecisions":[]}
DEBUG  [10:47:10:099] [RuleService][Debug] Getting Rules of Type VisitSchedule for Form - Dispatch receipt form 57bb2d3a-f8a5-4405-8d2c-514456e91533
DEBUG  [10:47:10:099] [RuleEvaluationService - Next Visits][Debug] []
DEBUG  [10:47:10:101] [TypedTransition][Debug] Route size: 4. To: /SystemRecommendationView Param Keys: {"form":{"that":BELOW_DEPTH},"decisions":{"enrolmentDecisions":BELOW_DEPTH,"encounterDecisions":BELOW_DEPTH,"registrationDecisions":BELOW_DEPTH},"individual":{"that":BELOW_DEPTH},"saveActionName":"EA.SAVE","onSaveCallback":function onSaveCallback(a0) { [bytecode] },"observations":[BELOW_DEPTH,BELOW_DEPTH,BELOW_DEPTH],"validationErrors":[],"headerMessage":"Dispatch receipt - Summary & Recommendations","checklists":[],"nextScheduledVisits":[],"message":"Dispatch receipt Encounter Saved","workListState":{"workLists":BELOW_DEPTH,"getParametersFn":BELOW_DEPTH},"isSaveDraftOn":false,"isRejectedEntity":undefined,"entityApprovalStatus":undefined,"onPreviousCallback":undefined,"affiliatedGroups":{}}
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Jun 25, 2024
@mahalakshme mahalakshme moved this from New Issues to Triaged in Avni Product Jun 25, 2024
@mahalakshme mahalakshme mentioned this issue Jun 25, 2024
@mahalakshme mahalakshme moved this from Triaged to Analysis Complete in Avni Product Jun 26, 2024
@mahalakshme mahalakshme moved this from Analysis Complete to Ready in Avni Product Jun 27, 2024
@mahalakshme mahalakshme changed the title Infinite Loop in RuleService Unable to go to Summary page Jun 27, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Jun 28, 2024
@petmongrels petmongrels self-assigned this Jun 28, 2024
@petmongrels
Copy link
Contributor

not reproducible on 9.x

@petmongrels petmongrels moved this from In Progress to Further Action Required in Avni Product Jul 1, 2024
@petmongrels petmongrels moved this from Further Action Required to Done in Avni Product Jul 2, 2024
@mahalakshme
Copy link
Contributor

@petmongrels I am able to reproduce the issue - tried with the same encounter as in the ticket

Steps to reproduce:

  • 9.0.2 apk, prod env, maha@goonj,
  • Open the dispatch with name "2024/KER/ACC-30007/KER/494"
  • Click on edit of the completed encounter
  • Click on Summary button on top right

Screenshot:

Image

Screen recording:

https://drive.google.com/file/d/13K-jrguVVBqCruWPH9vfwCOAUOvyQUcM/view?usp=drive_link

@mahalakshme mahalakshme moved this from Done to Ready in Avni Product Jul 2, 2024
@vinayvenu vinayvenu reopened this Jul 2, 2024
@github-project-automation github-project-automation bot moved this from Ready to Triaged in Avni Product Jul 2, 2024
@mahalakshme mahalakshme moved this from Triaged to Ready in Avni Product Jul 2, 2024
@1t5j0y 1t5j0y moved this from Ready to In Progress in Avni Product Jul 2, 2024
@1t5j0y 1t5j0y self-assigned this Jul 2, 2024
1t5j0y added a commit that referenced this issue Jul 3, 2024
if last FEG does not have any form elements to display
@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Jul 3, 2024
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Jul 3, 2024
@petmongrels petmongrels moved this from In Code Review to QA Ready in Avni Product Jul 3, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jul 4, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants