Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEA] Issue with subject form element #1173

Closed
Tracked by #1507
mahalakshme opened this issue Mar 19, 2024 · 4 comments
Closed
Tracked by #1507

[DEA] Issue with subject form element #1173

mahalakshme opened this issue Mar 19, 2024 · 4 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Mar 19, 2024

Context:

From this and this cards, support for subject form element was already added in DEA.

Issue:

env: staging
org: hello
Login username: AchalaB@hello
From this video, you can see it breaks when 'Search option' enabled on a form element(with Subject concept type) for a Group subject type

Also check with the above fix, being able to add a subject as value on Individual subject type will also get sorted. If not, this can be moved to separate card.
Image

Technical analysis:

  • Issue seems to be in SubjectFormElement.js file linked in LandingSubjectFormElement.js.
  • The component AsyncSelect in SubjectFormElement.js file, is similar to the one used in GroupMembershipAddEdit.js where logic for adding members to a group resides.
@mahalakshme mahalakshme converted this from a draft issue Mar 19, 2024
@mahalakshme mahalakshme changed the title Issue with subject form element [DEA] Issue with subject form element Mar 19, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Mar 19, 2024
@1t5j0y 1t5j0y moved this from Ready to In Progress in Avni Product Mar 21, 2024
@1t5j0y 1t5j0y self-assigned this Mar 21, 2024
1t5j0y added a commit that referenced this issue Mar 21, 2024
@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Mar 21, 2024
@vinayvenu vinayvenu moved this from Code Review Ready to In Code Review in Avni Product Apr 12, 2024
@vinayvenu vinayvenu moved this from In Code Review to QA Ready in Avni Product Apr 12, 2024
@vinayvenu vinayvenu moved this from QA Ready to In QA in Avni Product May 3, 2024
@AchalaBelokar
Copy link

  • I login with AchalaB@hello and try to add try to register there it is showing me error Cannot read property level of undefined
  • and I tested with AchalaB@rwbmh which is working fine

@AchalaBelokar AchalaBelokar moved this from In QA to QA Failed in Avni Product May 23, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented May 23, 2024

Issue appears to be because 8.0 is deployed to staging and this is a fix in 9.0

@1t5j0y 1t5j0y moved this from QA Failed to QA Ready in Avni Product May 23, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product May 23, 2024
@AchalaBelokar
Copy link

  • still it is failing

@AchalaBelokar AchalaBelokar moved this from In QA to QA Failed in Avni Product May 24, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented May 24, 2024

This change is on webapp while the issue Achala is reporting is on client for a specific org.
Verified that change on webapp is working fine:

Image

@1t5j0y 1t5j0y moved this from QA Failed to QA Ready in Avni Product May 24, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to Done in Avni Product May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants