Rework types to allow Parameters<typeof filesize> to function properly #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a usage in a codebase that relies on the types of the parameters. Initially our code looked something like:
However since this change (#172) change that is no longer possible. There is a larger thread in the typescript repo about this.
This PR reworks the types so that they are automatically inferred by the type of
options
passed and avoids overloads.An alternative to this would be export all the possible option types and return types, but you can get the same result using
Parameters
andReturnType
utility types.TypeScript Playground Link