Update to Rust 1.39.0 #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanmckay
force-pushed
the
avr-support-1.39.0-4560ea788c
branch
3 times, most recently
from
365524b
to
c848ae0
Compare
This commit fixes debug printing of function pointers on AVR. AVR does not support `addrspacecast` instructions, and so this patch modifies libcore so that a `ptrtoint` IR instruction is used and the address space cast is avoided.
Add extra steps for macOS, as noted in #131
Evidently there's some difference, see #144 (comment)
dylanmckay
force-pushed
the
avr-support-1.39.0-4560ea788c
branch
from
c848ae0
to
63b09c5
Compare
|
Can compile blink as is with just a rebase, except I did have to cherry-pick https://reviews.llvm.org/D68524 to fix #92. |
|
It compiled all of libcore - in all 146,564 lines of unoptimized avr asm glory: |
…onvention" This fixes #92. At the time of cherry-picking, this patch has not yet been upstreamed.
|
I say to push it! |
|
Hey @dylanmckay, @shepmaster, thanks for all your work on this! What is still missing for this version to be fully released? |
|
@Rahix can you pull this branch, compile it, and see if it still compiles your local test programs? That would probably prove useful. |
|
I agree - if this branch still works (why shouldn't it), let's update the HEADs. Also need to submit PRs upstream for avr-rust things. Start unforking this thing. |
|
Might just have been too late at night and me doing something stupid, but I can't seem to compile libcore with this branch. Running , I get a segfault :/ Stacktrace: Anything else I should provide to help? |
|
Adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.