Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Used syntax mismatches minimum_required version #1067

Closed
sbngross opened this issue Aug 14, 2022 · 2 comments · Fixed by #1243
Closed

cmake: Used syntax mismatches minimum_required version #1067

sbngross opened this issue Aug 14, 2022 · 2 comments · Fixed by #1243
Assignees
Labels
bug Something isn't working

Comments

@sbngross
Copy link
Contributor

install commands in src/CMakeLists.txt have the TYPE attribute. This syntax was introduced in cmake 3.14

minimum_required_version is 3.12.

Came across it when I tested my PR with a stone-age debian 10. There is a cmake 3.13.
It just runs in qemu so I can't provide logs, but this error is obvious.

The question remains how to deal with it. Raise min_req_ver or get rid of new syntax?

PS: We had to adapt the man install anyway to the DESTINATION syntax for #1063

@mcuee
Copy link
Collaborator

mcuee commented Aug 15, 2022

I tend to think it is easier to raise the minimum_required_version to 3.14. But let's hear from @mariusgreuel or @dl8dtl.

@mcuee mcuee added the bug Something isn't working label Aug 15, 2022
@mcuee
Copy link
Collaborator

mcuee commented Sep 5, 2022

@mariusgreuel
Please help to check this one. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants