man-page: Fix logfile short option #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
man synopsis states [-n -logfile] option. Later on in avrdude.1 as well as in main.c -l is used. Also '-logfile' is no option alternative but a parameter. This is a minor issue but still confusing when one uses / to search through man pages. -- Always leave the code cleaner than you found it -- Signed-off-by: brutzzl3r <s3b.gr0ss@gmail.com>
|
Well spotted and thanks for reporting! I suggest merging this PR next time when two or three have bunched up. |
`avrdude.1` is installed into `man` dir instead of its proper section location. This is due to the definition of `TYPE MAN` which points to `<DATAROOT>/man` according to cmake docs. Use `DESTINATION` and add proper section subdir. This allows for `man -M <YOUR INSTALL dir>/share/man -w 1 avrdude` to succeed instead of throwing `No manual entry for avrdude in section 1` Signed-off-by: brutzzl3r <s3b.gr0ss@gmail.com>
|
Fixes #1064 |
|
I can confirm that this pull requrst fixed #1064. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
man synopsis states [-n -logfile] option. Later on in avrdude.1 as well as in
main.c -l is used.
Also '-logfile' is no option alternative but a parameter.
This is a minor issue but still confusing when one uses / to search
through man pages.
Fixing this issue brought another one into light. As it is closely related put this fix on top of this one as agreed upon.
-- Always leave the code cleaner than you found it --
Signed-off-by: brutzzl3r s3b.gr0ss@gmail.com