Implement a dry run for -U updates before opening the programmer #1056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks -U update requests for
before opening the programmer. This to reduce the chances of the programming failing midway through.
Whilst the
update_dryrun()
goes through some of the checks ofdo_op()
, the functionality ofdo_op()
has not been changed, so applications that usedo_op()
from libavrdude will work the same.Needs thorough testing for cases where the dry run exits when, without it, the command would legitimately work. It is possible to construct cases where the dry run misses opportunities to check, but this is not an issue as this will be done during the real work.
Minor additional changes:
avoid name clashes when an application links with it
Examples: