-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readline for macOS github build #1149
Conversation
Fore link readline brew keg an force build with readline instead of libedit, for macOS Homebrew
Typo fix
One more try to link the keg version of readline under macOS
One more try to link the keg version of readline under macOS
Update build.sh to use readline keg for macOS Homebrew
Thanks for the PR! There are quite a few commits and not that many changes to the codebase. One of the commits removes a line, while the next one adds it back again, but is slightly modified. Maybe you could try to squash/combine a few commits that "does the same thing"? Thanks! |
You are right. I was carrying out trial and error to see what works for github action. I am still learning to use git (usally only using I think this PR needs more testing as well, for example, for people using MacPorts (supposedly to work as no changes for MacPorts users). |
I think I messed up my git repo somehow. I will close this one and create a new one. |
This pull request adds the support for readline for the github action macOS Homebrew build. It will use readline instead of libedit.
Sign-off by xiaofanc@gmail.com