Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readline for macOS github build #1149

Closed
wants to merge 9 commits into from
Closed

Conversation

mcuee
Copy link
Collaborator

@mcuee mcuee commented Oct 23, 2022

This pull request adds the support for readline for the github action macOS Homebrew build. It will use readline instead of libedit.

Sign-off by xiaofanc@gmail.com

Fore link readline brew keg an force build with readline instead of libedit, for macOS Homebrew
Typo fix
One more try to link the keg version of readline under macOS
One more try to link the keg version of readline under macOS
No need the brew link force step
Update build.sh to use readline keg for macOS Homebrew
@MCUdude
Copy link
Collaborator

MCUdude commented Oct 23, 2022

Thanks for the PR!

There are quite a few commits and not that many changes to the codebase. One of the commits removes a line, while the next one adds it back again, but is slightly modified. Maybe you could try to squash/combine a few commits that "does the same thing"? Thanks!

@mcuee
Copy link
Collaborator Author

mcuee commented Oct 24, 2022

Thanks for the PR!

There are quite a few commits and not that many changes to the codebase. One of the commits removes a line, while the next one adds it back again, but is slightly modified. Maybe you could try to squash/combine a few commits that "does the same thing"? Thanks!

@MCUdude

You are right. I was carrying out trial and error to see what works for github action. I am still learning to use git (usally only using git clone, git pull and git checkout). I will see what I can do.

I think this PR needs more testing as well, for example, for people using MacPorts (supposedly to work as no changes for MacPorts users).

@mcuee
Copy link
Collaborator Author

mcuee commented Oct 24, 2022

I think I messed up my git repo somehow. I will close this one and create a new one.

@mcuee mcuee closed this Oct 24, 2022
@mcuee mcuee deleted the readline_macos branch October 24, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants