Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configure.ac to reflect HAVE_READLINE statue #1280

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Update configure.ac to reflect HAVE_READLINE statue #1280

merged 1 commit into from
Jan 13, 2023

Conversation

mcuee
Copy link
Collaborator

@mcuee mcuee commented Jan 13, 2023

No description provided.

@mcuee mcuee added the bug Something isn't working label Jan 13, 2023
@mcuee mcuee mentioned this pull request Jan 13, 2023
Closed
@mcuee
Copy link
Collaborator Author

mcuee commented Jan 13, 2023

Test results:

@mcuee mcuee merged commit 9cf4f55 into avrdudes:main Jan 13, 2023
@mcuee
Copy link
Collaborator Author

mcuee commented Jan 13, 2023

I would not update NEWS as this auto-tools build is no longer supported.

@mcuee mcuee deleted the configure_ac_readline branch January 13, 2023 05:30
@mcuee
Copy link
Collaborator Author

mcuee commented Jan 13, 2023

There is a github Linux x86_64 build error after merging. That seems to be a temp issue from github side.

@dl8dtl
Copy link
Contributor

dl8dtl commented Jan 13, 2023

There is a github Linux x86_64 build error after merging. That seems to be a temp issue from github side.

I restarted the job.

@dl8dtl
Copy link
Contributor

dl8dtl commented Jan 13, 2023

Unable to connect to azure.archive.ubuntu.com:http: [IP: 20.106.104.242 80]

Nothing we are responsible for.

@mcuee
Copy link
Collaborator Author

mcuee commented Jan 13, 2023 •
edited
Loading

I have also generated the source tarball to be used with a configure script here, it seems to work fine under Ubuntu Linux 20.04, macOS and MSYS2 mingw.

https://github.com/mcuee/avrdude/releases/tag/v7.1
https://github.com/mcuee/avrdude/releases/download/v7.1/avrdude-7.1-20230108.tar.gz

@mcuee
Copy link
Collaborator Author

mcuee commented Jan 13, 2023

Unable to connect to azure.archive.ubuntu.com:http: [IP: 20.106.104.242 80]

Nothing we are responsible for.

Now the github issue has been resolved.

@mcuee
Copy link
Collaborator Author

mcuee commented Jan 14, 2023 •
edited
Loading

@MCUdude

Maybe you can also give the git main a try to use auto-tools.

macOS build log here.
#957 (comment)

@mcuee mcuee mentioned this pull request Jan 30, 2023
Closed
mcuee added a commit to mcuee/avrdude that referenced this pull request Jan 30, 2023
@mcuee
Revert PR avrdudes#1280
b00a768 
This will fix issue avrdudes#1296
@mcuee
Copy link
Collaborator Author

mcuee commented Jan 30, 2023

Unfortunately this breaks macOS terminal mode. So we have to revert this.

mcuee added a commit that referenced this pull request Jan 31, 2023
@mcuee
Merge pull request #1297 from mcuee/revert_pr1280
dd7b359 
Revert PR #1280
@mcuee mcuee mentioned this pull request Oct 13, 2023
Merged
@mcuee mcuee mentioned this pull request Feb 6, 2024
Merged
@ndim
Copy link
Contributor

ndim commented Feb 6, 2024 •
edited
Loading

This comment is just to remind me to look into this later (post 7.3).

@mcuee mcuee mentioned this pull request Feb 6, 2024
Closed
@mcuee
Copy link
Collaborator Author

mcuee commented Feb 6, 2024

This comment is just to remind me to look into this later (post 7.3).

I have created a new issue to track this.

@ndim
Copy link
Contributor

ndim commented Feb 8, 2024 •
edited
Loading

I think I have solved this in #1681 b510973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcuee @dl8dtl @ndim