-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden AVRDUDE against pre-C99 libraries #1608
Conversation
Looks good except it generates new warnings from MSYS2 mingw compiler. From github action MSYS2 mingw64 build
You do not see such warnings with git main. Please refer to the github action build log with git main. |
BTW, once you merge this into git main, then the Arduino avrdude-packing script in avrdude repo will run. As of now the script does not run on pull-requests and only upon push to git main. https://github.com/avrdudes/avrdude/blob/main/.github/workflows/arduino_packing.yml
|
Another thing, it seems that you are correct that Windows 7 C runtime is not really compatible with C99. But then I do not understand why MinGW MSYS2 build does not have the issue with Hex file type automatic recognition, since it also uses However, our default MSYS2 build environment are mingw32 and mingw64 and not ucrt64.
|
Maybe one is statically linked and one dynamically. The problem is the scanf() library function at execution. |
Now this PR is good to go. Please merge this so that we can confirm whether the |
I have created a new PR to add MSYS2 ucrt64, clang32 and clang64 build. clang compilers sometimes capture more codes issues compared to gcc and MSVC. |
Apparently, some Windows 7 systems have C libraries that are not C99 compliant. This PR hardens against these problems.