Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new field, new source and updated fillable_by fields for insura… #87

Merged
merged 10 commits into from
Nov 13, 2019

Conversation

Reallife
Copy link
Collaborator

@Reallife Reallife commented Nov 1, 2019

…nce.* fields

Q A
Bug fix? No
New feature? Yes

Description

Added

  • Source ramiosago.base.ext #86
  • Field with path insurance.osago.items[].policy.is_active #86

Changed

  • Field with path insurance.osago.items[].policy.number also fillable by ramiosago.base.ext #86
  • Field with path insurance.osago.items[].policy.series also fillable by ramiosago.base.ext #86
  • Field with path insurance.osago.items[].restrictions.type also fillable by ramiosago.base.ext #86
  • Field with path insurance.osago.items[].date.end also fillable by ramiosago.base.ext #86
  • Field with path insurance.osago.items[].date.start also fillable by ramiosago.base.ext #86
  • Field with path insurance.osago.items[].insurer.name also fillable by ramiosago.base.ext #86
  • Field with path insurance.osago.items[].number also fillable by ramiosago.base.ext #86

Fixed

  • Field with path insurance.osago.items[].date.end also fillable by ramiosago.base in fields_list.json #86
  • Field with path insurance.osago.items[].date.start also fillable by ramiosago.base in fields_list.json #86
  • Makefile task test-php now run only composer test command. It's fix double phpstan check call

Fixes #86

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code
  • I have made changes in CHANGELOG.md file

@Reallife Reallife requested a review from tarampampam as a code owner November 1, 2019 13:07
fields/default/fields_list.json Outdated Show resolved Hide resolved
sdk/php/tests/SpecificationsTest.php Show resolved Hide resolved
sdk/php/tests/SpecificationsTest.php Outdated Show resolved Hide resolved
@Reallife Reallife merged commit 0f79bc6 into master Nov 13, 2019
@Reallife Reallife deleted the add-new-report-fields-and-ramiosago-base-ext-source branch November 13, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant