Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64 support. #128

Closed
awalsh128 opened this issue Mar 3, 2024 · 6 comments
Closed

arm64 support. #128

awalsh128 opened this issue Mar 3, 2024 · 6 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@awalsh128
Copy link
Owner

awalsh128 commented Mar 3, 2024

This came up as a result of #127 involving @atilsensalduz and @koppor. The PR should fix the issue as a workaround. Issue originally came up because binaries were being used compiled for amd64 in the new apt-query command being used in the bash scripts.

Still need to add the regression to the CI. I authorized BuildJet as suggested in the PR thread but it looks like there is no free tier. On first look at the pricing I shouldn't exceed $0.01 but still need to make sure to avoid a surprise bill.

I also saw this https://github.com/pguyot/arm-runner-action/blob/main/action.yml and am wondering if we could use this as an alternative (will need to reproduce).

@awalsh128 awalsh128 self-assigned this Mar 3, 2024
@awalsh128
Copy link
Owner Author

Published https://github.com/awalsh128/cache-apt-pkgs-action/releases/tag/v1.4.2 as a pre-prod release.

@koppor and/or @atilsensalduz can you confirm this works for you and I will mark it as prod ready?

@awalsh128 awalsh128 added the help wanted Extra attention is needed label Mar 3, 2024
@awalsh128
Copy link
Owner Author

Actually just run against @master. I was able to address another issue #98 and am going to include it in a repackaged release of v1.4.2 if it works.

@atilsensalduz
Copy link

Hey @awalsh128, I've tested 1.4.2 it worked on ARM instances in my environment

@koppor
Copy link
Contributor

koppor commented Mar 4, 2024

@master Works here, too.

@awalsh128
Copy link
Owner Author

Thanks for confirming. Going to reroll the release with that other fix and update this issue when ready.

@awalsh128 awalsh128 added the bug Something isn't working label Mar 9, 2024
@awalsh128
Copy link
Owner Author

https://github.com/awalsh128/cache-apt-pkgs-action/releases/tag/v1.4.2 is now in prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants