Failing on v1.2.4 #98
Comments
|
Sorry to hear you are having trouble. I'll need to look at the diff > 1.2.4 to see what changes occurred. My feeling is that |
|
In pyvista/pyvista#3964, I removed the tkinter requirement and enabled debug logging: |
|
It looks like it is just showing standard output and the debug flag is false. Can you check to make sure the debug param is specified in the action and set to true. Running the action install phase locally doesn't replicate this issue. I am going to add a regression test for this on the CI. Also, FWIW I have rolled up a pre-release as v1.3.0 with other changes in it. It will reset the cache, so make sure to run the action a 2nd time if the 1st passes so both install and restore get tested. |
|
Looks like the latest pre-release now addresses your issue. Can you confirm? v1.2.4 - fails - https://github.com/awalsh128/cache-apt-pkgs-action-ci/actions/runs/4517518290 |
|
@awalsh128 Sorry it is still failing. What could we do for it? |
|
Tried adding some tests to replicate the issue but I can't seem to. The error is different than it was last time. Unfortunately this error is rather nebulous because there is no message. Was this ran with the |
|
@awalsh128 Yes, I set |
|
No problem. I'm thinking we can take the action your product uses and trim it down to the minimal setup that causes the error. Suggestions on where to start? Build Doc stage? |
|
Hi @tkoyama010, bumping this. |
awalsh128
added
bug
|
Thanks. We will try it. |
|
We are checking it in pyvista/pyvista#5151 . |
|
Hi @tkoyama010, just reviewing tickets and wanted to check in on this. |
|
Thanks for your mention. This is the newest dependabot PR. It seems that we still have the same issue. |
|
Okay finally found the root cause. It is the addition of exit on error overriding the action script behavior. env:
...
SHELLOPTS: errexit:pipefail
...I was able to recreate the problem with: name: Isolated Dev Test
on:
workflow_dispatch:
inputs:
debug:
description: "Run in debug mode."
type: boolean
required: false
default: true
env:
DEBUG: ${{ github.event.inputs.debug || false }}
SHELLOPTS: errexit:pipefail
jobs:
regression_98_v2:
runs-on: ubuntu-latest
name: "Temporary test for PyVista doc cache failures (regression issue #98)."
steps:
- uses: actions/checkout@v3.1.0
- uses: awalsh128/cache-apt-pkgs-action@dev
with:
packages: python3-tk
version: ${{ github.run_id }}-${{ github.run_attempt }}-regression_98_v2
debug: trueThen verify in the runs.
Explicitly turned this off in the library that uses it in f2fc6d1. Can you verify by pointing your action to master? |
|
Thanks. I'll try. |
@awalsh128 It is working! Thanks a lot! I cannot wait for the next release. |
|
Great to hear! I'll roll this up in a new release of v1.4.2. Will update the issue when it is ready and your DependaBot update should clear it. |
pyvista/pyvista#3964 has failed since the release of v1.2.4
The logs aren't clear. Do you have any suggestions?
I've even updated the cache version, but the issue persists:
Full GitHub action log:
The text was updated successfully, but these errors were encountered: