Dev wireframe tetrahedron

[tcper]

Created a Wireframe Tetrahedron for away3d, with atomic git commit.

The main purpose of this pull request is to find out whether my code style is fit for the project. :)

Waiting for your feedback.

[richardolsson]

Thanks! I'll review this in more depth and potentially merge it!

[tcper]

:)

I've a question is that, I wrote some test samples when create this class,
I think that these samples has their values, the project doesn't include any samples,
How do you handle this problem before?

Loki.Tang
已使用 Sparrow (http://www.sparrowmailapp.com/?sig)

已使用 Sparrow (http://www.sparrowmailapp.com/?sig)

在 2012年7月29日星期日，上午12:28，Richard Olsson 写道：

Thanks! I'll review this in more depth and potentially merge it!

---

Reply to this email directly or view it on GitHub:
#375 (comment)

[richardolsson]

There is a separate repository for examples, at http://github.com/away3d/away3d-examples-fp11

If you have an example that you would like us to include there, study the conventions and create a pull request using the same general structure as the existing examples in that repo.

Btw, your commits are if possible a little bit too atomic. There is no need to commit right after creating a class from a template, before there is any functionality in it. Your first three commits related to the WireframeTetrahedron class (or even all four) could have been a single commit, since the class is basically useless until after the buildGeometry() function has been implemented.

Also, consider that your commit messages would be part of the log for the entire Away3D library, so try to mention what system/class you're working on. A commit message like "create the constructor" doesn't reveal at all what part of the library you have been working on, so "Created the WireframeTetrahedron constructor" would have been a better choice (disregarding the fact that this particular commit maybe shouldn't have been a separate commit at all, as previously discussed.)

[tcper]

Thanks for the feedback, I will correct it ASAP.

[rob-bateman]

merged with dev branch. For new functionality in pull requests, please always target the dev branch - these days master only receives critical bug patches for the current stable release.

Please could you verify functionality in dev, feel free to also add an example to the away3d-examples-fp11 repo!