-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes michaeldv/awesome_print#218 #222
Conversation
Explicitly requires rake and bundle as developement dependencies at awesme_print.gemspec, following the convention used by the 'bundle gem' command. Requiring rake at the top of the gemspec caused an error in environments without rake installed, resulting in a failed 'bundle install'.
Some travis builds fail because of the specified bundler version.
Ok, I clearly missed something important. It's a classic "Works in my machine" case but I get a lot of errors in different travis builds. The ones marked with an exclamation sign (!) output the following:
And this is for most of the builds. A few of them pass and there are a couple that fail (marked with an X) with the following:
And my guess is that it is unrelated to my changes. I love this gem and would love to contribute with something meaningful in the future, but maybe I'm doing something wrong here. Any help? Thanks in advance! |
@aleandros It seems the last time a master build came back successful, the nobrainer specs were skipped: That skip was due to the following skip condition: Which basically just checks if NoBrainer is defined: I'm not sure why it's defined now when on previous runs it was not defined as nothing has changed in the code. Perhaps a change to the environment in which Travis runs it's tests. Either way this is not due to your changes. |
Running a new build now: https://travis-ci.org/gerrywastaken/awesome_print/builds/129529176 Apparently there is no way to force a complete rebuild of the Travis build associated with this PR (and others) without pushing another commit to it: travis-ci/travis-ci#6031 (comment) |
Oh and this PR seems to be almost the same as this one: #216 |
You're right. The only difference seems to be adding rake directly as a development dependency. Now I'm not sure if that's even necessary. |
Both awesome-print#216 and awesome-print#222 fixed this and waited a long time for a response so I thought it best to add both to the credits in the change log.
Never mind, how about we close this one just give you some credit in the change log instead: Thanks heaps for the PR though, it's really appreciated. |
Wow, I really appreciate that. Thanks! |
Your change went live in version 1.7.0. Thank you. :) |
Explicitly requires rake and bundle as developement
dependencies at awesme_print.gemspec, following
the convention used by the 'bundle gem' command.
Requiring rake at the top of the gemspec caused
an error in environments without rake installed, resulting
in a failed 'bundle install'.