Fix Travis mime-types dependency issue #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix some of our Travis builds failed with:
Gem::InstallError: mime-types-data requires Ruby version >= 2.0.
Idea for the fix was found here:
sgruhier/foundation_rails_helper#116
Although we could not use the same method as I only want to lock
down the version of mime-type where necessary. Also trying to lock
the version to 2.6.2 would break our Rails-3.2 Appraisal path.
|
Note: The checks which are still failing were failing before this commit. |
|
This fix is in version 1.7.0 |
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix some of our Travis builds failed (during the gem install
stage) with:
Idea for the fix was found here:
sgruhier/foundation_rails_helper#116
Although we could not use the same method as I only want to lock
down the version of mime-type where necessary. Also trying to lock
the version to 2.6.2 would break our Rails-3.2 Appraisal path.
Before (on the main repo):
After (on my fork):
Note: The error seen in 22.4 was already failing it's just that it was hidden by the gem installation breaking.