-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add data logging api in defineData
#2359
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We should move couple of things around to reduce public api additions.
* - The generated request/response functions that were resolved for each field. | ||
* @default 'none' | ||
*/ | ||
level?: DataLogLevel; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be named fieldLogLevel
just as you described in the default example in the docs above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching the discrepancy in the doc. fieldLogLevel
is used in the cdk. But I think level
as the API is more straightforward and aligns with what we already have in defineFunction
. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does AppSync have other log levels ? for example modelLogLevel
?
If it does have it or have potential to have it in the future then - would we add second "level property" here or use this level
to feed both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find any other log level besides fieldLogLevel
. I'm confirming if AppSync has plan to add other log levels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But thanks for the catch. I think it's better to name it fieldLogLevel
for clarity and to differentiate in case AppSync has plan later to add other log level
🦋 Changeset detectedLatest commit: aa42129 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Kamil Sobol <sobkamil@amazon.com>
…kend into data-logging-api
Changes
This PR added data logging options in
defineData
. Summary of changes:data-construct
version to consume the new logging apiDataLogLevel
typeDataLogLevelConverter
and logging options parserconvertLoggingOptionsToCDK
Validation
Unit tests added for:
DataLogLevelConverter
convertLoggingOptionsToCDK
defineData
with logging optionsChecklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.