fix: Change 'rds' to 'sql' in public-facing symbols #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
commented
Nov 14, 2023
| RDSPatchingLambdaLogAccessPolicy: 'RDSPatchingLambdaLogAccessPolicy', | ||
| RDSPatchingLambdaLogicalID: 'RDSPatchingLambdaLogicalID', | ||
| RDSLambdaDataSourceLogicalID: 'RDSLambdaDataSource', | ||
| RDSLambdaDataSourceLogicalName: 'RDSLambdaDatabase', |
There was a problem hiding this comment.
Note: I removed this constant -- it was not in use anywhere and was easily confused with RDSLambdaDataSourceLogicalID.
palpatim
commented
Nov 14, 2023
| SQLPatchingLambdaLogAccessPolicy: 'SQLPatchingLambdaLogAccessPolicy', | ||
| SQLPatchingLambdaLogicalID: 'SQLPatchingLambda', | ||
| SQLLambdaDataSourceLogicalID: 'SQLLambdaDataSource', | ||
| SQLPatchingSubscriptionLogicalID: 'SQLPatchingSubscription', |
There was a problem hiding this comment.
Note that I added SQLPatchingSubscriptionLogicalID and SQLPatchingTopicLogicalID, which were previously hardcoded in the subscription creation logic
alharris-at
previously approved these changes
Nov 14, 2023
Comment on lines
+61
to
+62
| // For beta use account '956468067974', layer name 'AmplifySQLLayerBeta' and layer version '12' as of 2023-06-20 | ||
| // For prod use account '582037449441', layer name 'AmplifySQLLayer' and layer version '3' as of 2023-06-20 |
There was a problem hiding this comment.
Not a blocker, but comment is out of date.
palpatim
force-pushed
the
palpatim.fix.change-rds-to-sql
branch
from
c597591
to
9f0dab7
Compare
alharris-at
approved these changes
Nov 15, 2023
dpilch
approved these changes
Nov 15, 2023
2 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change leaves most of the internal symbols unchanged, but should pick up the public-facing ones. Notably:
This PR does NOT override ‘RDS’ in resolver template output, since that would bloat the size of the PR and those files aren't generally reviewed by customers anyway.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.