chore: Remove unused Amplify managed table & RDS transformer & generator #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
force-pushed
the
palpatim.chore.remove-unused-model-xformer
branch
2 times, most recently
from
99e42c8 to
46d6c27
Compare
palpatim
force-pushed
the
palpatim.chore.remove-unused-model-xformer
branch
from
46d6c27 to
810e55a
Compare
|
Gen2 RDS tests still use Gen 1 RDS functionality to provision the stack. Once we get all of our tests no longer using Gen 1 CLI, we can revisit this effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes the SQL and Amplify-managed DDB table logic from
@aws-amplify/graphql-model-transformer:This PR is not technically a prerequisite for it, but I'm doing this as part of the work for #3006.
Although the functional changes in this PR are limited to
@aws-amplify/graphql-model-transformer, it has broad-reaching implications for tests elsewhere, since we make heavy use of snapshot tests and the generated resources will no longer contain SQL or Amplify-managed resolvers. Thus, this PR touches or deletes 91(!) files. This PR simply removes RDS & Amplify-managed DDB tests.Finally, removing the RDS tests reduced coverage in some cases; those coverage thresholds have been adjusted down accordingly.
Issue #, if available
#3006
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.