Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add recommendation of pull request breakdown to contributing guides #11412

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

danielleadams
Copy link
Contributor

@danielleadams danielleadams commented Nov 16, 2022

Description of changes

Adds more guidance on opening a pull request so that it's easier for CLI team members to review:

  1. Recommends breaking down pull requests greater than 12 files changed.
  2. Recommends making an initial pull request with linting changes.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danielleadams danielleadams requested a review from a team as a code owner November 16, 2022 18:08
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #11412 (01135ac) into dev (6e02691) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev   #11412   +/-   ##
=======================================
  Coverage   49.45%   49.45%           
=======================================
  Files         692      692           
  Lines       33424    33424           
  Branches     6840     6840           
=======================================
+ Hits        16529    16530    +1     
+ Misses      15370    15369    -1     
  Partials     1525     1525           
Impacted Files Coverage Δ
...li/src/domain/amplify-usageData/getUsageDataUrl.ts 100.00% <0.00%> (+12.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@danielleadams danielleadams merged commit 0c05c63 into aws-amplify:dev Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants